Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go SDK]: Adds Automated Python Expansion Service #23582

Merged
merged 7 commits into from
Oct 18, 2022
Merged

[Go SDK]: Adds Automated Python Expansion Service #23582

merged 7 commits into from
Oct 18, 2022

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented Oct 11, 2022 •
edited
Loading

Added an automated python expansion service for Go SDK.

Part of #23385

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the go label Oct 11, 2022
@riteshghorse
Copy link
Contributor Author

Failure are due to use of core.SdkVersion which points to .dev. Did testing with fixed version locally and it passes. Filtering the test for now.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@riteshghorse
Copy link
Contributor Author

R: @lostluck

@codecov
Copy link

codecov bot commented Oct 11, 2022 •
edited
Loading

Codecov Report

Merging #23582 (5642ac7) into master (3ffdf8d) will decrease coverage by 0.09%.
The diff coverage is 1.58%.

❗ Current head 5642ac7 differs from pull request most recent head d014585. Consider uploading reports for the commit d014585 to get more accurate results

@@            Coverage Diff             @@
##           master   #23582      +/-   ##
==========================================
- Coverage   73.40%   73.30%   -0.10%     
==========================================
  Files         719      719              
  Lines       95940    96064     +124     
==========================================
- Hits        70424    70423       -1     
- Misses      24205    24329     +124     
- Partials     1311     1312       +1
Flag Coverage Δ
go 50.65% <1.58%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/xlangx/expand.go 0.00% <0.00%> (ø)
...kg/beam/core/runtime/xlangx/expansionx/download.go 13.60% <0.00%> (-3.07%) ⬇️
sdks/go/pkg/beam/core/runtime/xlangx/registry.go 44.85% <0.00%> (-2.48%) ⬇️
...pkg/beam/core/runtime/xlangx/expansionx/process.go 61.40% <18.18%> (-11.52%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

lostluck
lostluck approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one tiny change.

@lostluck lostluck merged commit fac0d03 into apache:master Oct 18, 2022
@riteshghorse riteshghorse mentioned this pull request Oct 18, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostluck lostluck lostluck approved these changes

Assignees
No one assigned
Labels
go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riteshghorse @lostluck